HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1821119914
##########
solr/solrj-zookeeper/build.gradle:
##########
@@ -37,6 +37,13 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.httpcomponents:httpcore'
+
+ implementation('org.apache.curator:curator-client', {
+ exclude group: 'org.apache.zookeeper', module: 'zookeeper'
+ })
+ api('org.apache.curator:curator-framework', {
Review Comment:
Ok, tried it, and it won't work. Our `ZkACLProvider` is a sub-class of
Curator's `ACLProvider`. Therefore, people using solrj-zookeeper and ACLs will
be unable to compile without the api dependency. Changing back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
