HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1811505686
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -1187,25 +1178,19 @@ private void createEphemeralLiveNode() throws
KeeperException, InterruptedExcept
String nodePath = ZkStateReader.LIVE_NODES_ZKNODE + "/" + nodeName;
log.info("Register node as live in ZooKeeper:{}", nodePath);
Map<NodeRoles.Role, String> roles = cc.nodeRoles.getRoles();
- List<Op> ops = new ArrayList<>(roles.size() + 1);
- ops.add(
- Op.create(
- nodePath,
- null,
- zkClient.getZkACLProvider().getACLsToAdd(nodePath),
Review Comment:
CuratorFramework has an ACLProvider built in, which we supply, so the ACLs
don't need to be added in the command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
