dsmiley commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1819655529
##########
solr/solrj-zookeeper/build.gradle:
##########
@@ -37,6 +37,13 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.httpcomponents:httpcore'
+
+ implementation('org.apache.curator:curator-client', {
+ exclude group: 'org.apache.zookeeper', module: 'zookeeper'
+ })
+ api('org.apache.curator:curator-framework', {
Review Comment:
This is mostly a matter of taste; nothing is breaking based on this decision
(I think). Solr-core already has an explicit dependency so that point is moot.
I believe the impact would be some SolrJ user who adds solrj-zookeeper because
they want to use ZK coordinates for CloudSolrClient. Their runtime class path
will have Curator either way. But do we want such a user to have their
compile-time class-path with Curator as well? Like; are they *likely* to use
Curator explicitly? If we don't think it's *likely*, I think "implementation"
best communicates an internal scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
