libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905659276
@davidradl > * I don't think we can have 0 key names for a lookup join. Have you a test case that would drive this ? There is no such restriction in semantic (maybe somewhere has a checker logic to disallow this, maybe not), anyway, it doesn't affect here, semantically we can handle it when there is no keys. > * the ? test. We can leave this in , but it allows column names with ?s in - which seems like a good thing. We could do this in a separate issue if you want. Yes, this is an orthogonal issue to current one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
