libenchao commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1461286671
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTablePlanTest.java:
##########
@@ -70,6 +98,51 @@ public void testFilterPushdown() {
"SELECT id, time_col, real_col FROM jdbc WHERE id = 900001 AND
time_col <> TIME '11:11:11' OR double_col >= -1000.23");
}
+ /**
+ * Note the join condition is not present in the optimized plan, as it is
handled in the JDBC
Review Comment:
> just for my understanding ar we thinking that the rowdata sent in on the
lookup would contain the pushdown predicates so the code could call and this
would handle the predicates and the keys:
> statement = lookupKeyRowConverter.toExternal(keyRow, statement);
> we could then remove the need for?
> statement = setPredicateParams(statement);
What I was proposing is showing the predicates in the digest of lookup join
node. That way, we can see it in the test xml files, and also it can be shown
in Flink Web UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
