davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905641356
> @davidradl @snuyanzin I reviewed, and added a few cosmetic changes in [commit](https://github.com/libenchao/flink-connector-jdbc/commit/24caa99cd97e86afb1836886d51007775ed95ddc), others looks good to me, please take a look. If you agree on this version, I'll proceed with merging. > > https://github.com/libenchao/flink-connector-jdbc/commits/33365-lookup-join-predicate-pushdown/ @libenchao than you very much for your help on this. I am happy with the cosmetic fixups . I had 2 comments I added to the code. - I don't think we can have 0 key names for a lookup join. Have you a test case that would drive this ? - the ? test. We can leave this in , but it allows column names with ?s in - which seems like a good thing. We could do this in a separate issue if you want. If we can get to a consensus on these, I am happy for it to merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
