davidradl commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1460466435
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java:
##########
@@ -116,6 +124,15 @@ public void open(FunctionContext context) throws Exception
{
}
}
+ private FieldNamedPreparedStatement
setPredicateParams(FieldNamedPreparedStatement statement)
+ throws SQLException {
+ for (int i = 0; i < pushdownParams.length; ++i) {
Review Comment:
@snuyanzin I am not finding a way to scaffold a unit test around this method
and prove the cases work. It looks like I need to prepare the statement and
then populate rowdata and then run through the converter before I can setup the
statement required for this method. I will continue to investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
