snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1463057026
########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java: ########## @@ -56,13 +57,16 @@ public class JdbcRowDataLookupFunction extends LookupFunction { private static final Logger LOG = LoggerFactory.getLogger(JdbcRowDataLookupFunction.class); private static final long serialVersionUID = 2L; - private final String query; + private String query; private final JdbcConnectionProvider connectionProvider; - private final String[] keyNames; + private String[] keyNames; Review Comment: nit ```suggestion private final String[] keyNames; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org