snuyanzin commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1463064026
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunctionTest.java:
##########
@@ -82,6 +103,121 @@ void testLookup(boolean withFailure) throws Exception {
assertThat(result).isEqualTo(expected);
}
+ @ParameterizedTest
+ @MethodSource("lookupWithPredicatesProvider")
+ public void testEval(TestSpec testSpec) throws Exception {
Review Comment:
```suggestion
void testEval(TestSpec testSpec) throws Exception {
```
no need for `public` since it is junit5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
