snuyanzin commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1458074979
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java:
##########
@@ -116,6 +124,15 @@ public void open(FunctionContext context) throws Exception
{
}
}
+ private FieldNamedPreparedStatement
setPredicateParams(FieldNamedPreparedStatement statement)
+ throws SQLException {
+ for (int i = 0; i < pushdownParams.length; ++i) {
Review Comment:
It seems that currently so far there no test checking what happens if we
enter inside this loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
