davidradl commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1458658676
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/statement/FieldNamedPreparedStatementImpl.java:
##########
@@ -178,26 +178,42 @@ public void close() throws SQLException {
//
----------------------------------------------------------------------------------------
public static FieldNamedPreparedStatement prepareStatement(
- Connection connection, String sql, String[] fieldNames) throws
SQLException {
+ Connection connection,
+ String sql,
+ String[] fieldNames,
+ String additionalPredicates,
+ int numberOfDynamicParams)
+ throws SQLException {
checkNotNull(connection, "connection must not be null.");
checkNotNull(sql, "sql must not be null.");
checkNotNull(fieldNames, "fieldNames must not be null.");
- if (sql.contains("?")) {
Review Comment:
If there is a column name with a ? character in - then it will fail -
removing this check tolerates column names like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
