davidradl commented on PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1898097633
> @davidradl Thanks for the work. I think the
`testSelectStatementWithWeirdCharacters` you added is an orthogonal problem
with current one, it fails without current changes, right? If yes, it can be
another separate issue which does not block current one.
>
> Current issue is mainly about how to let JDBC lookup function handle the
pushed predicates, previously it just ignored them. So one test case I would
like to see is one ITCase test, which shows that the result is correct with
predicates pushed down.
@libenchao Yes the join key with weird colon characters failed before. We
are now adding filters that use the same mechanism and will not work with
colons. The index approach works with all characters.
Based on this , I will put this code without the weird character unit test
into this pr with the extra unit test that you suggest. I will raise a separate
issue for the colon characters issue. @snuyanzin any concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
