davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1896205523
Hi @libenchao @snuyanzin , I have got the POC mostly working. I added fixups and some junits to [https://github.com/davidradl/flink-connector-jdbc/tree/pushdown-predidates-to-lookup-function](https://github.com/davidradl/flink-connector-jdbc/tree/pushdown-predidates-to-lookup-function ). This works for me locally, but it fails with column names or join keys containing colons. I do think this is a better approach than the indexes solution in the pr - thankyou @libenchao :-) I have included a failing junit showing the problem. https://github.com/davidradl/flink-connector-jdbc/blob/59f47bc8f659b9a1c4440dcf0fd9ae70ecaba9c3/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/statement/FieldNamedPreparedStatementImplTest.java#L152 The unit test has a join key name with a `:` at the end, the FieldNamedPreparedStatementImpl parseNamedStatement method finds the colon and nothing after it - so assume there is an invalid empty name. Is this acceptable as `:` are unusual in column names and is baked into the current design of FieldNamedPreparedStatementImpl ? If not, any thoughts on how to fix this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
