ozankabak commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2126999507
##########
datafusion/catalog/src/listing_schema.rs:
##########
@@ -143,7 +141,7 @@ impl ListingSchemaProvider {
order_exprs: vec![],
unbounded: false,
options: Default::default(),
- constraints: Constraints::empty(),
+ constraints: Default::default(),
Review Comment:
I tried to conform to the existing style in the file. Some files use the
`Default::default` pattern, while others use `TypeName::default` pattern. I
agree that it'd be good if we have a uniform idiom for this case across the DF
codebase. Maybe we can make this a PR in the future if there turns out to be a
consensus on the style to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
