ozankabak commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2126896630
##########
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##########
@@ -210,24 +175,27 @@ async fn test_remove_unnecessary_sort5() -> Result<()> {
let left_schema = create_test_schema2()?;
let right_schema = create_test_schema3()?;
let left_input = memory_exec(&left_schema);
- let parquet_sort_exprs = vec![sort_expr("a", &right_schema)];
- let right_input = parquet_exec_sorted(&right_schema, parquet_sort_exprs);
-
+ let parquet_ordering = [sort_expr("a", &right_schema)].into();
+ let right_input =
+ parquet_exec_with_sort(right_schema.clone(), vec![parquet_ordering]);
let on = vec![(
Arc::new(Column::new_with_schema("col_a", &left_schema)?) as _,
Arc::new(Column::new_with_schema("c", &right_schema)?) as _,
)];
let join = hash_join_exec(left_input, right_input, on, None,
&JoinType::Inner)?;
- let physical_plan = sort_exec(vec![sort_expr("a", &join.schema())], join);
+ let physical_plan = sort_exec([sort_expr("a", &join.schema())].into(),
join);
- let expected_input = ["SortExec: expr=[a@2 ASC],
preserve_partitioning=[false]",
+ let expected_input = [
Review Comment:
Yep, let's make a push for those after we merge this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
