ozankabak commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2126871133
##########
datafusion/physical-expr/src/equivalence/ordering.rs:
##########
@@ -164,51 +124,40 @@ impl OrderingEquivalenceClass {
/// For example, if `orderings[idx]` is `[a ASC, b ASC, c DESC]` and
/// `orderings[pre_idx]` is `[b ASC, c DESC]`, then the function will trim
/// `orderings[idx]` to `[a ASC]`.
- fn resolve_overlap(&mut self, idx: usize, pre_idx: usize) -> bool {
+ fn resolve_overlap(&mut self, idx: usize, pre_idx: usize) -> Option<bool> {
Review Comment:
Exactly, will update the docstring accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
