ozankabak commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2126891646
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -1053,25 +1051,9 @@ impl TableProvider for ListingTable {
file_extension: self.options().format.get_ext(),
};
- let order_requirements = if !self.options().file_sort_order.is_empty()
{
- // Multiple sort orders in outer vec are equivalent, so we pass
only the first one
- let orderings = self.try_create_output_ordering()?;
- let Some(ordering) = orderings.first() else {
- return internal_err!(
- "Expected ListingTable to have a sort order, but none
found!"
- );
- };
- // Converts Vec<Vec<SortExpr>> into type required by execution
plan to specify its required input ordering
- Some(LexRequirement::new(
- ordering
- .into_iter()
- .cloned()
- .map(PhysicalSortRequirement::from)
- .collect::<Vec<_>>(),
- ))
- } else {
- None
- };
+ let orderings = self.try_create_output_ordering()?;
+ // It is sufficient to pass only one of the equivalent orderings:
Review Comment:
Agreed 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
