ozankabak commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2126879246
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -2581,7 +2581,7 @@ async fn test_count_wildcard_on_sort() -> Result<()> {
| | TableScan: t1 projection=[b]
|
| physical_plan | ProjectionExec: expr=[b@0 as b, count(*)@1 as count(*)]
|
| | SortPreservingMergeExec: [count(Int64(1))@2 ASC NULLS
LAST] |
- | | SortExec: expr=[count(Int64(1))@2 ASC NULLS LAST],
preserve_partitioning=[true] |
+ | | SortExec: expr=[count(*)@1 ASC NULLS LAST],
preserve_partitioning=[true] |
Review Comment:
IIRC this is a byproduct of how constants are handled (i.e. without special
treatment in equivalence checks). It is indeed non-obvious, but is safe (unless
I'm missing something).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
