Garamda commented on code in PR #13511:
URL: https://github.com/apache/datafusion/pull/13511#discussion_r1976291064
##########
datafusion/expr/src/udaf.rs:
##########
@@ -845,6 +861,19 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
ScalarValue::try_from(data_type)
}
+ /// If this function supports `[IGNORE NULLS | RESPECT NULLS]` clause,
return true
+ /// If the function does not, return false
+ /// Otherwise return None (the default)
+ fn supports_null_handling_clause(&self) -> Option<bool> {
+ None
+ }
+
+ /// If this function is ordered-set aggregate function, return true
+ /// If the function is not, return false
+ fn is_ordered_set_aggregate(&self) -> Option<bool> {
+ None
Review Comment:
I agree. I have applied it to the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
