vbarua commented on code in PR #13511:
URL: https://github.com/apache/datafusion/pull/13511#discussion_r1972603943
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -146,6 +146,10 @@ pub struct SessionState {
scalar_functions: HashMap<String, Arc<ScalarUDF>>,
/// Aggregate functions registered in the context
aggregate_functions: HashMap<String, Arc<AggregateUDF>>,
+ /// Ordered-set aggregate functions registered in the context
+ ///
+ /// Note : ordered_set_aggregate_functions are a subset of
aggregate_functions.
+ ordered_set_aggregate_functions: HashMap<String, Arc<AggregateUDF>>,
Review Comment:
Another approach that could work for this is would be to include this
information in the `AggregateUDF` itself so that they can all be stored in
`aggregate_functions` together
There are already properties like `order_sensitivity`
https://github.com/apache/datafusion/blob/fb40506b3f8d90930d4bf2b8b00fca5a5eac11fe/datafusion/expr/src/udaf.rs#L268-L272
and `groups_accumulator_supported`
https://github.com/apache/datafusion/blob/fb40506b3f8d90930d4bf2b8b00fca5a5eac11fe/datafusion/expr/src/udaf.rs#L234-L237
that are incorporated directly into the UDAF definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
