Garamda commented on code in PR #13511:
URL: https://github.com/apache/datafusion/pull/13511#discussion_r1975605829
##########
datafusion/expr/src/expr.rs:
##########
@@ -724,6 +727,7 @@ impl AggregateFunction {
filter,
order_by,
null_treatment,
+ within_group,
Review Comment:
@vbarua I appreciate your elaborate review.
Actually, 'where to convert WITHIN GROUP into ORDER BY' was one of the
biggest things for me to consider.
I did not have clear standards when I started to work on this PR.
Your guide is right, so I refactored codes.
Would you review it?
I appreciate it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
