Garamda commented on code in PR #13511:
URL: https://github.com/apache/datafusion/pull/13511#discussion_r1976290842
##########
datafusion/core/tests/dataframe/dataframe_functions.rs:
##########
@@ -360,14 +360,15 @@ async fn test_fn_approx_median() -> Result<()> {
#[tokio::test]
async fn test_fn_approx_percentile_cont() -> Result<()> {
- let expr = approx_percentile_cont(col("b"), lit(0.5), None);
+ let expr =
+ approx_percentile_cont(Some(vec![col("b").sort(true, false)]),
lit(0.5), None);
let expected = [
- "+---------------------------------------------+",
- "| approx_percentile_cont(test.b,Float64(0.5)) |",
- "+---------------------------------------------+",
- "| 10 |",
- "+---------------------------------------------+",
+
"+----------------------------------------------------------------------------------+",
+ "| approx_percentile_cont(test.b,Float64(0.5)) WITHIN GROUP [test.b
ASC NULLS LAST] |",
Review Comment:
Thank you for identifying that. I have refactored the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
