Garamda commented on code in PR #13511: URL: https://github.com/apache/datafusion/pull/13511#discussion_r1976295147
########## datafusion/functions-aggregate/src/approx_percentile_cont.rs: ########## @@ -51,29 +52,43 @@ create_func!(ApproxPercentileCont, approx_percentile_cont_udaf); /// Computes the approximate percentile continuous of a set of numbers pub fn approx_percentile_cont( - expression: Expr, + within_group: Option<Vec<Sort>>, Review Comment: > It would probably be good to add a test for this if there isn't already Do you mean the test case like this https://github.com/apache/datafusion/pull/13511#discussion_r1938232489 ? If I misunderstood, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
