jayzhan211 commented on PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#issuecomment-2652335822
> get_valid_types() always coerces the outermost FixedSizeList to List, no
matter what the value of the flag is. I'm pretty sure that matches existing
behavior, but I don't fully understand it. So I just wanted to double check
with you that's it's correct
It is because of this, I think we now only coerce to list if the flag is set
```rust
fn array(array_type: &DataType) -> Option<DataType> {
match array_type {
DataType::List(_) | DataType::LargeList(_) =>
Some(array_type.clone()),
DataType::FixedSizeList(field, _) =>
Some(DataType::List(Arc::clone(field))),
_ => None,
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
