jayzhan211 commented on code in PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#discussion_r1951785203
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -94,7 +94,7 @@ impl Default for ArrayHas {
impl ArrayHas {
pub fn new() -> Self {
Self {
- signature: Signature::array_and_element(Volatility::Immutable),
+ signature: Signature::array_and_element(Volatility::Immutable,
None),
Review Comment:
but to avoid breaking `Signature::array_and_element` we can keep it.
(without additional array_coercion field)
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -94,7 +94,7 @@ impl Default for ArrayHas {
impl ArrayHas {
pub fn new() -> Self {
Self {
- signature: Signature::array_and_element(Volatility::Immutable),
+ signature: Signature::array_and_element(Volatility::Immutable,
None),
Review Comment:
but to avoid breaking `Signature::array_and_element` we can keep one without
additional array_coercion field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
