jkosh44 commented on PR #14532: URL: https://github.com/apache/datafusion/pull/14532#issuecomment-2651638551
@jayzhan211 I just pushed a commit with your idea about adding a flag for array coercion. I'm feeling pretty good about the state of this PR, but I have the following two open questions: - `get_valid_types()` always coerces the outermost `FixedSizeList` to `List`, no matter what the value of the flag is. I'm pretty sure that matches existing behavior, but I don't fully understand it. So I just wanted to double check with you that's it's correct. - Can you double check that I correctly assigned a function with `Some(ListCoercion::FixedSizedListToList)` vs `None` for the flag? I'm not 100% confident that I did it correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
