jayzhan211 commented on code in PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#discussion_r1951783336
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -94,7 +94,7 @@ impl Default for ArrayHas {
impl ArrayHas {
pub fn new() -> Self {
Self {
- signature: Signature::array_and_element(Volatility::Immutable),
+ signature: Signature::array_and_element(Volatility::Immutable,
None),
Review Comment:
How about something like this, we don't necessary need to wrap into a util
function, it is less helpful when there are many fields
```rust
signature: Signature {
type_signature: TypeSignature::ArraySignature(
ArrayFunctionSignature::Array {
arguments: vec![
ArrayFunctionArgument::Array,
ArrayFunctionArgument::Element,
],
array_coercion:
Some(ListCoercion::FixedSizedListToList),
},
),
volatility: Volatility::Immutable,
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
