alamb commented on code in PR #14276:
URL: https://github.com/apache/datafusion/pull/14276#discussion_r1937635455
##########
datafusion/functions/src/core/named_struct.rs:
##########
@@ -203,12 +137,19 @@ impl ScalarUDFImpl for NamedStructFunc {
))))
}
- fn invoke_batch(
Review Comment:
> My assumption was that ScalarUDFImpl is SPI
Yes, that is accurate in my understanding
> and invoke_batch was kept around to not break all existing implementations
Yes that is also my understanding
> and ScalarFunctionExpr is the API side of things which doesn't expose
invoke_batch. Is that a correct interpretation?
I would say `ScalarFunctionExpr` is an implementation detail of how
functions are invoked in the `ExecutionPlan` (aka the physical execution)
The split between logical/physical plans is explained a bit in the API docs
/ intro videos in case you are interested:
https://docs.rs/datafusion/latest/datafusion/index.html#query-planning-and-execution-overview
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
