pepijnve opened a new pull request, #14276:
URL: https://github.com/apache/datafusion/pull/14276
By implementing `invoke_with_args` the fields derived in
return_type(_from_args) can be reused (performance) and the duplicate
derivation logic can be removed.
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #14275.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Reusing the already derived fields results in a small, but measurable,
performance improvement according to the added micro benchmark.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Replaces the `invoke_batch` implementations with `invoke_with_args`
implementations.
## Are these changes tested?
Covered by the existing dataframe/dataframe_functions tests
## Are there any user-facing changes?
Not at the SQL level. At the library level calls to `invoke_batch` for these
two functions will result in a runtime error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
