lichuang commented on code in PR #14276: URL: https://github.com/apache/datafusion/pull/14276#discussion_r1929516369
########## datafusion/functions/src/core/named_struct.rs: ########## @@ -203,12 +137,19 @@ impl ScalarUDFImpl for NamedStructFunc { )))) } - fn invoke_batch( Review Comment: If delete `invoke_batch` function, the default `invoke_batch` function will call `invoke` when args is not empty, but `invoke` function is left impl be Specific type, is it ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org