pepijnve commented on code in PR #14276:
URL: https://github.com/apache/datafusion/pull/14276#discussion_r1929519836
##########
datafusion/functions/src/core/named_struct.rs:
##########
@@ -203,12 +137,19 @@ impl ScalarUDFImpl for NamedStructFunc {
))))
}
- fn invoke_batch(
Review Comment:
I wasn't sure what the intention is for the deprecated functions from an API
user point of view. I had interpreted ScalarUDF(Impl) as an extension point
rather than as public API that library users would call directly. If that
assumption is correct, then it doesn't matter if we remove the `invoke_batch`
implementation since `ScalarFunctionExpr` never calls this method. The only
usages of `invoke_batch` are in benchmark and test code.
Perhaps @alamb, who logged #13515, can provide some insight here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
