pepijnve commented on code in PR #14276:
URL: https://github.com/apache/datafusion/pull/14276#discussion_r1937117565
##########
datafusion/functions/src/core/named_struct.rs:
##########
@@ -203,12 +137,19 @@ impl ScalarUDFImpl for NamedStructFunc {
))))
}
- fn invoke_batch(
Review Comment:
I'm coming from the Java world so I'll use the terminology from there; not
sure what the equivalent is in Rust lingo. It's not explicitly stated which
parts of the library are [Service Provider
Interface](https://en.wikipedia.org/wiki/Service_provider_interface) vs
[Application Programming Interface](https://en.wikipedia.org/wiki/API). My
assumption was that `ScalarUDFImpl` is SPI and `invoke_batch` was kept around
to not break all existing implementations and `ScalarFunctionExpr` is the API
side of things which doesn't expose `invoke_batch`. Is that a correct
interpretation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
