findepi commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1763412711
##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -49,17 +48,8 @@ impl Default for EncodeFunc {
impl EncodeFunc {
pub fn new() -> Self {
- use DataType::*;
Self {
- signature: Signature::one_of(
Review Comment:
Null to T coercion needs to be handled elsewhere anyway (eg when computing
type of a UNION, etc.).
We can free functions from having to bother about coercions at all and let
the engine calculate coercions when building the logical plan.
This is actually super fundamental for DataFusion vision as a composable
query engine. Coercion rules are very implementation-specific. If we had
functions spiced up with coercions inside them, that would make those functions
non-reusable.
cc @wizardxz @sadboy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
