mesejo commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1746233299
##########
datafusion/functions/src/core/coalesce.rs:
##########
@@ -60,12 +60,16 @@ impl ScalarUDFImpl for CoalesceFunc {
}
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
- Ok(arg_types[0].clone())
+ Ok(arg_types
+ .iter()
+ .find_or_first(|d| !d.is_null())
+ .unwrap()
+ .clone())
}
- // If all the element in coalesce is non-null, the result is non-null
+ // If all the elements in coalesce are non-null, the result is non-null
fn is_nullable(&self, args: &[Expr], schema: &dyn ExprSchema) -> bool {
- args.iter().any(|e| e.nullable(schema).ok().unwrap_or(true))
+ args.iter().all(|e| e.nullable(schema).ok().unwrap_or(true))
Review Comment:
I am having some sqllogictests fail in the CI
([link](https://github.com/mesejo/arrow-datafusion/actions/runs/10728724019/job/29753866598)),
but executing:
```bash
cargo test --test sqllogictests
```
Passes on my local machine. Have you experienced something similar?
**Note:** The error message says that it only received a prefix of the
actual message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
