jayzhan211 commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1766067330


##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -49,17 +48,8 @@ impl Default for EncodeFunc {
 
 impl EncodeFunc {
     pub fn new() -> Self {
-        use DataType::*;
         Self {
-            signature: Signature::one_of(

Review Comment:
   @findepi Are you suggesting something like general coercion that is 
non-function specific? But what if we want different coercion rule for 
different function, we might need to do coercion function wise



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to