jayzhan211 commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1769452189
##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -49,17 +48,8 @@ impl Default for EncodeFunc {
impl EncodeFunc {
pub fn new() -> Self {
- use DataType::*;
Self {
- signature: Signature::one_of(
Review Comment:
My idea is that it is more flexible to the user, although, without the real
use case, it might be a premature optimization 🤔.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
