alamb commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1763545855
##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -49,17 +48,8 @@ impl Default for EncodeFunc {
impl EncodeFunc {
pub fn new() -> Self {
- use DataType::*;
Self {
- signature: Signature::one_of(
Review Comment:
100%
It seems to me like `Signature` is supposed to communicate what types the
function implementation has a native implementation for and the coercion of
whatever the user provided doesn't match one of the supported types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
