andygrove commented on code in PR #735:
URL: https://github.com/apache/datafusion-comet/pull/735#discussion_r1715605905
##########
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##########
@@ -192,6 +192,13 @@ class CometJoinSuite extends CometTestBase {
// DataFusion HashJoin LeftAnti has bugs in handling nulls and is
disabled for now.
// left.join(right, left("_2") === right("_1"), "leftanti")
+
+ // Full join: struct key
Review Comment:
I think we could improve our test framework to make it easier to test for
fallback but it is possible with code like this (must be used after calling
collect on a DataFrame). I think we can improve the tests in a future PR.
```
val str =
new
ExtendedExplainInfo().generateExtendedInfo(df.queryExecution.executedPlan)
assert(str.contains(expectedMessage))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
