eejbyfeldt commented on code in PR #735:
URL: https://github.com/apache/datafusion-comet/pull/735#discussion_r1714808516
##########
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##########
@@ -192,6 +192,13 @@ class CometJoinSuite extends CometTestBase {
// DataFusion HashJoin LeftAnti has bugs in handling nulls and is
disabled for now.
// left.join(right, left("_2") === right("_1"), "leftanti")
+
+ // Full join: struct key
Review Comment:
We do fallback currently. Is there someway or even desired to add a test for
that?
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2718,11 +2718,6 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
return None
}
- if ((join.leftKeys ++
join.rightKeys).exists(_.dataType.isInstanceOf[StructType])) {
- withInfo(join, "Unsupported struct data type in join keys")
- return None
- }
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
