eejbyfeldt commented on code in PR #735:
URL: https://github.com/apache/datafusion-comet/pull/735#discussion_r1710119011
##########
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##########
@@ -192,6 +192,13 @@ class CometJoinSuite extends CometTestBase {
// DataFusion HashJoin LeftAnti has bugs in handling nulls and is
disabled for now.
// left.join(right, left("_2") === right("_1"), "leftanti")
+
+ // Full join: struct key
Review Comment:
Good call will add more test cases. Created #797 to make it easier to create
nulls of struct type.
> Also, what happens with structs containing unsupported types such as array
and map?
Do you mean unsupported by comet here? I think the answer for `map` is that
spark does not support joining on `map` so it will fail during the Spark
planning stage. I will add a test for array by I guess that requires something
like #793 first since we do not support reading arrays from parquet. Or is
there some other way testing with arrays?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
