andygrove commented on code in PR #735:
URL: https://github.com/apache/datafusion-comet/pull/735#discussion_r1708187757
##########
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##########
@@ -192,6 +192,13 @@ class CometJoinSuite extends CometTestBase {
// DataFusion HashJoin LeftAnti has bugs in handling nulls and is
disabled for now.
// left.join(right, left("_2") === right("_1"), "leftanti")
+
+ // Full join: struct key
Review Comment:
Thanks for adding the test. I wonder if we should make this more
comprehensive to cover structs containing different types, nulls, and nested
structs?
Also, what happens with structs containing unsupported types such as array
and map? Do we still fall back for those? It would be good to have a test for
this case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
