viirya commented on code in PR #735:
URL: https://github.com/apache/datafusion-comet/pull/735#discussion_r1710123942
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2718,11 +2718,6 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
return None
}
- if ((join.leftKeys ++
join.rightKeys).exists(_.dataType.isInstanceOf[StructType])) {
- withInfo(join, "Unsupported struct data type in join keys")
- return None
- }
Review Comment:
We should further check if the data types are supported using
`supportedDataType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
