-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/05/11 03:49, Diego Novillo wrote: > On Tue, Apr 5, 2011 at 10:50, Eric Botcazou <ebotca...@adacore.com> wrote: >>> I definitely think that if there is a policy change that an allowance be >>> made for weekends/holidays and that if a patch has been identified and >>> the offender has acknowledged the issue and is actively working on the >>> problem give the offender time to resolve the issue. >> >> This weekends/holidays allowance would be dangerous and counter-productive: >> people would rush to install risky changes on Friday and leave for the >> week-end fingers crossed. This would be worse than the current policy IMO. > > I agree. If it's broken, it should be taken out. It doesn't make a > lot of difference to the patch owner, and if the fix takes more than a > day or so to be produced, then the cost of the breakage is much > higher. As an example, I recently broke ObjC++, and the fix for it > took more than 3-4 days to get in. My patch should've been reverted > in the meantime. It can make a huge difference if the owner has been unable to reproduce and is waiting on the reporter to provide enough information to reproduce or debug the problem.
I the case of the current x86 breakage, the only problem I've been aware of was an internal report from bkoz that bootstrap was breaking on x86_64 (with no other details). Meanwhile my bootstraps were running fine. It wasn't until HJ's autotester reported the key "--disable-checking" configury bits that we were able to confirm a problem and start the real process of diagnosing what went wrong. Jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNmxxoAAoJEBRtltQi2kC7ShUH/A5sQ+9Hyu3E9AxEyyVWuCl8 FSu/szFMK4Qm/ES9LzFp/uVgfF9f5qKQSIJ9h4zC6IiByJqgerlBt3y2SpN3RZhS OMh76Jk7bnVjeOoHes1ZLxkWN3Eey73Q57WyH9jyqmSouTZqpPG686QBd17Lkslu 79d6BVz3YCFagZtNGES74HJAMJUrlrt5ywu1UEwKvMVrOOjOgLv4mzJ/xwb+3nM+ yRt9AcIm5adzqdiqg5TPb4ncm67BD34lwQOzJATgrc724+9jp0TQMhcC5U/AoOGS vExVGwxyS8Zhl2JOa5oSl3Re+fXcczUwfkhn5Nfncxr2yo/JVuV3m4309Rz6/kw= =hC4Y -----END PGP SIGNATURE-----
