+1 (non binding) Checked signature, checksum, license, and tests.
Had a few flaky tests running on M1 Mac, listed below. I reran the tests on ubuntu using github runners <https://github.com/kevinjqliu/iceberg-python/actions/runs/13251043031/job/36988731699> and it completed successfully. I also tested against pyiceberg's integration tests on my fork <https://github.com/kevinjqliu/iceberg-python/pull/9>. Thanks for running the release! Best, Kevin Liu Flaky tests: ``` > Task :iceberg-aws:test TestS3FileIO > testDeleteFilesSingleBatchWithRemainder() FAILED org.apache.iceberg.io.BulkDeletionFailureException: Failed to delete 18 files at app//org.apache.iceberg.aws.s3.S3FileIO.deleteFiles(S3FileIO.java:240) at app//org.apache.iceberg.aws.s3.TestS3FileIO.testBatchDelete(TestS3FileIO.java:231) at app//org.apache.iceberg.aws.s3.TestS3FileIO.testDeleteFilesSingleBatchWithRemainder(TestS3FileIO.java:186) TestS3FileIO > testDeleteFilesMultipleBatches() FAILED org.apache.iceberg.io.BulkDeletionFailureException: Failed to delete 30 files at app//org.apache.iceberg.aws.s3.S3FileIO.deleteFiles(S3FileIO.java:240) at app//org.apache.iceberg.aws.s3.TestS3FileIO.testBatchDelete(TestS3FileIO.java:231) at app//org.apache.iceberg.aws.s3.TestS3FileIO.testDeleteFilesMultipleBatches(TestS3FileIO.java:176) TestS3FileIO > testDeleteFilesLessThanBatchSize() FAILED org.apache.iceberg.io.BulkDeletionFailureException: Failed to delete 12 files at app//org.apache.iceberg.aws.s3.S3FileIO.deleteFiles(S3FileIO.java:240) at app//org.apache.iceberg.aws.s3.TestS3FileIO.testBatchDelete(TestS3FileIO.java:231) at app//org.apache.iceberg.aws.s3.TestS3FileIO.testDeleteFilesLessThanBatchSize(TestS3FileIO.java:181) > Task :iceberg-core:test TestHadoopCommits > testConcurrentFastAppends(File) FAILED org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in org.apache.iceberg.hadoop.TestHadoopCommits was not fulfilled within 10 seconds. at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167) at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78) at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26) at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006) at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975) at app//org.apache.iceberg.hadoop.TestHadoopCommits.lambda$testConcurrentFastAppends$3(TestHadoopCommits.java:462) ``` On Mon, Feb 10, 2025 at 11:45 AM Anurag Mantripragada < anuragmantr...@gmail.com> wrote: > +1 > > I verified signature, checksums, license, built and ran tests locally. > > Thanks for taking care of the release, Amogh! > > Thanks, > Anurag > > On Sun, Feb 9, 2025 at 10:39 PM Amogh Jahagirdar <2am...@gmail.com> wrote: > >> Hi Everyone, >> >> I propose that we release the following RC as the official Apache Iceberg >> 1.8.0 release. >> >> The commit ID is c277c2014a1b37fe755cfe37f173b6465bb8cb73 >> * This corresponds to the tag: apache-iceberg-1.8.0-rc0 >> * https://github.com/apache/iceberg/commits/apache-iceberg-1.8.0-rc0 >> * >> https://github.com/apache/iceberg/tree/c277c2014a1b37fe755cfe37f173b6465bb8cb73 >> >> The release tarball, signature, and checksums are here: >> * https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.8.0-rc0 >> >> You can find the KEYS file here: >> * https://downloads.apache.org/iceberg/KEYS >> >> Convenience binary artifacts are staged on Nexus. The Maven repository >> URL is: >> * >> https://repository.apache.org/content/repositories/orgapacheiceberg-1182/ >> >> Please download, verify, and test. >> >> Please vote in the next 72 hours. >> >> [ ] +1 Release this as Apache Iceberg 1.8.0 >> [ ] +0 >> [ ] -1 Do not release this because... >> >> Only PMC members have binding votes, but other community members are >> encouraged to cast >> non-binding votes. This vote will pass if there are 3 binding +1 votes >> and more binding >> +1 votes than -1 votes. >> >
