+0 (binding) I don't think committers should be allowed to approve their own changes. I would prefer if non-committer contributors can approve committer PRs as that would encourage more participation in code review and ability to contribute.
On Fri, Aug 16, 2019 at 9:02 PM Shaoxuan Wang <wshaox...@gmail.com> wrote: > +1 (binding) > > On Fri, Aug 16, 2019 at 7:48 PM Chesnay Schepler <ches...@apache.org> > wrote: > > > +1 (binding) > > > > Although I think it would be a good idea to always cc > > priv...@flink.apache.org when modifying bylaws, if anything to speed up > > the voting process. > > > > On 16/08/2019 11:26, Ufuk Celebi wrote: > > > +1 (binding) > > > > > > – Ufuk > > > > > > > > > On Wed, Aug 14, 2019 at 4:50 AM Biao Liu <mmyy1...@gmail.com> wrote: > > > > > >> +1 (non-binding) > > >> > > >> Thanks for pushing this! > > >> > > >> Thanks, > > >> Biao /'bɪ.aʊ/ > > >> > > >> > > >> > > >> On Wed, 14 Aug 2019 at 09:37, Jark Wu <imj...@gmail.com> wrote: > > >> > > >>> +1 (non-binding) > > >>> > > >>> Best, > > >>> Jark > > >>> > > >>> On Wed, 14 Aug 2019 at 09:22, Kurt Young <ykt...@gmail.com> wrote: > > >>> > > >>>> +1 (binding) > > >>>> > > >>>> Best, > > >>>> Kurt > > >>>> > > >>>> > > >>>> On Wed, Aug 14, 2019 at 1:34 AM Yun Tang <myas...@live.com> wrote: > > >>>> > > >>>>> +1 (non-binding) > > >>>>> > > >>>>> But I have a minor question about "code change" action, for those > > >>>>> "[hotfix]" github pull requests [1], the dev mailing list would not > > >> be > > >>>>> notified currently. I think we should change the description of > this > > >>>> action. > > >>>>> > > >>>>> [1] > > >>>>> > > >> > > > https://flink.apache.org/contributing/contribute-code.html#code-contribution-process > > >>>>> Best > > >>>>> Yun Tang > > >>>>> ________________________________ > > >>>>> From: JingsongLee <lzljs3620...@aliyun.com.INVALID> > > >>>>> Sent: Tuesday, August 13, 2019 23:56 > > >>>>> To: dev <dev@flink.apache.org> > > >>>>> Subject: Re: [VOTE] Flink Project Bylaws > > >>>>> > > >>>>> +1 (non-binding) > > >>>>> Thanks Becket. > > >>>>> I've learned a lot from current bylaws. > > >>>>> > > >>>>> Best, > > >>>>> Jingsong Lee > > >>>>> > > >>>>> > > >>>>> ------------------------------------------------------------------ > > >>>>> From:Yu Li <car...@gmail.com> > > >>>>> Send Time:2019年8月13日(星期二) 17:48 > > >>>>> To:dev <dev@flink.apache.org> > > >>>>> Subject:Re: [VOTE] Flink Project Bylaws > > >>>>> > > >>>>> +1 (non-binding) > > >>>>> > > >>>>> Thanks for the efforts Becket! > > >>>>> > > >>>>> Best Regards, > > >>>>> Yu > > >>>>> > > >>>>> > > >>>>> On Tue, 13 Aug 2019 at 16:09, Xintong Song <tonysong...@gmail.com> > > >>>> wrote: > > >>>>>> +1 (non-binding) > > >>>>>> > > >>>>>> Thank you~ > > >>>>>> > > >>>>>> Xintong Song > > >>>>>> > > >>>>>> > > >>>>>> > > >>>>>> On Tue, Aug 13, 2019 at 1:48 PM Robert Metzger < > > >> rmetz...@apache.org> > > >>>>>> wrote: > > >>>>>> > > >>>>>>> +1 (binding) > > >>>>>>> > > >>>>>>> On Tue, Aug 13, 2019 at 1:47 PM Becket Qin <becket....@gmail.com > > >>>>> wrote: > > >>>>>>>> Thanks everyone for voting. > > >>>>>>>> > > >>>>>>>> For those who have already voted, just want to bring this up to > > >>>> your > > >>>>>>>> attention that there is a minor clarification to the bylaws > > >> wiki > > >>>> this > > >>>>>>>> morning. The change is in bold format below: > > >>>>>>>> > > >>>>>>>> one +1 from a committer followed by a Lazy approval (not > > >> counting > > >>>> the > > >>>>>>> vote > > >>>>>>>>> of the contributor), moving to lazy majority if a -1 is > > >>> received. > > >>>>>>>> > > >>>>>>>> Note that this implies that committers can +1 their own commits > > >>> and > > >>>>>> merge > > >>>>>>>>> right away. *However, the committe**rs should use their best > > >>>>>> judgement > > >>>>>>> to > > >>>>>>>>> respect the components expertise and ongoing development > > >> plan.* > > >>>>>>>> > > >>>>>>>> This addition does not really change anything the bylaws meant > > >> to > > >>>>> set. > > >>>>>> It > > >>>>>>>> is simply a clarification. If anyone who have casted the vote > > >>>>> objects, > > >>>>>>>> please feel free to withdraw the vote. > > >>>>>>>> > > >>>>>>>> Thanks, > > >>>>>>>> > > >>>>>>>> Jiangjie (Becket) Qin > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> On Tue, Aug 13, 2019 at 1:29 PM Piotr Nowojski < > > >>>> pi...@ververica.com> > > >>>>>>>> wrote: > > >>>>>>>> > > >>>>>>>>> +1 > > >>>>>>>>> > > >>>>>>>>>> On 13 Aug 2019, at 13:22, vino yang <yanghua1...@gmail.com > > >>>>> wrote: > > >>>>>>>>>> +1 > > >>>>>>>>>> > > >>>>>>>>>> Tzu-Li (Gordon) Tai <tzuli...@apache.org> 于2019年8月13日周二 > > >>>>> 下午6:32写道: > > >>>>>>>>>>> +1 > > >>>>>>>>>>> > > >>>>>>>>>>> On Tue, Aug 13, 2019, 12:31 PM Hequn Cheng < > > >>>>> chenghe...@gmail.com> > > >>>>>>>>> wrote: > > >>>>>>>>>>>> +1 (non-binding) > > >>>>>>>>>>>> > > >>>>>>>>>>>> Thanks a lot for driving this! Good job. @Becket Qin < > > >>>>>>>>>>> becket....@gmail.com > > >>>>>>>>>>>> Best, Hequn > > >>>>>>>>>>>> > > >>>>>>>>>>>> On Tue, Aug 13, 2019 at 6:26 PM Stephan Ewen < > > >>>> se...@apache.org > > >>>>>>>> wrote: > > >>>>>>>>>>>>> +1 > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> On Tue, Aug 13, 2019 at 12:22 PM Maximilian Michels < > > >>>>>>> m...@apache.org > > >>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>> > > >>>>>>>>>>>>>> +1 It's good that we formalize this. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> On 13.08.19 10:41, Fabian Hueske wrote: > > >>>>>>>>>>>>>>> +1 for the proposed bylaws. > > >>>>>>>>>>>>>>> Thanks for pushing this Becket! > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> Cheers, Fabian > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> Am Mo., 12. Aug. 2019 um 16:31 Uhr schrieb Robert > > >>> Metzger > > >>>> < > > >>>>>>>>>>>>>>> rmetz...@apache.org>: > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> I changed the permissions of the page. > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> On Mon, Aug 12, 2019 at 4:21 PM Till Rohrmann < > > >>>>>>>>>>>> trohrm...@apache.org> > > >>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> +1 for the proposal. Thanks a lot for driving this > > >>>>>> discussion > > >>>>>>>>>>>>> Becket! > > >>>>>>>>>>>>>>>>> Cheers, > > >>>>>>>>>>>>>>>>> Till > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> On Mon, Aug 12, 2019 at 3:02 PM Becket Qin < > > >>>>>>>>>>> becket....@gmail.com> > > >>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>> Hi Robert, > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> That's a good suggestion. Will you help to change > > >> the > > >>>>>>>>>>> permission > > >>>>>>>>>>>> on > > >>>>>>>>>>>>>>>> that > > >>>>>>>>>>>>>>>>>> page? > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> Thanks, > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> Jiangjie (Becket) Qin > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> On Mon, Aug 12, 2019 at 2:41 PM Robert Metzger < > > >>>>>>>>>>>>> rmetz...@apache.org> > > >>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> Thanks for starting the vote. > > >>>>>>>>>>>>>>>>>>> How about putting a specific version in the wiki > > >> up > > >>>> for > > >>>>>>>>>>> voting, > > >>>>>>>>>>>> or > > >>>>>>>>>>>>>>>>>>> restricting edit access to the page to the PMC? > > >>>>>>>>>>>>>>>>>>> There were already two changes (very minor) to the > > >>>> page > > >>>>>>> since > > >>>>>>>>>>>> the > > >>>>>>>>>>>>>>>> vote > > >>>>>>>>>>>>>>>>>> has > > >>>>>>>>>>>>>>>>>>> started: > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> > > >> > > > https://cwiki.apache.org/confluence/pages/viewpreviousversions.action?pageId=120731026 > > >>>>>>>>>>>>>>>>>>> I suggest to restrict edit access to the page. > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> On Mon, Aug 12, 2019 at 11:43 AM Timo Walther < > > >>>>>>>>>>>> twal...@apache.org > > >>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>>> +1 > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> Thanks for all the efforts you put into this for > > >>>>>>> documenting > > >>>>>>>>>>>> how > > >>>>>>>>>>>>>>>> the > > >>>>>>>>>>>>>>>>>>>> project operates. > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> Regards, > > >>>>>>>>>>>>>>>>>>>> Timo > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> Am 12.08.19 um 10:44 schrieb Aljoscha Krettek: > > >>>>>>>>>>>>>>>>>>>>> +1 > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> On 11. Aug 2019, at 10:07, Becket Qin < > > >>>>>>>>>>> becket....@gmail.com> > > >>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>>>>> Hi all, > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> I would like to start a voting thread on the > > >>>> project > > >>>>>>> bylaws > > >>>>>>>>>>>> of > > >>>>>>>>>>>>>>>>>> Flink. > > >>>>>>>>>>>>>>>>>>> It > > >>>>>>>>>>>>>>>>>>>>>> aims to help the community coordinate more > > >>>> smoothly. > > >>>>>>> Please > > >>>>>>>>>>>> see > > >>>>>>>>>>>>>>>>> the > > >>>>>>>>>>>>>>>>>>>> bylaws > > >>>>>>>>>>>>>>>>>>>>>> wiki page below for details. > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> > > >> > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=120731026 > > >>>>>>>>>>>>>>>>>>>>>> The discussion thread is following: > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> > > >> > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Flink-project-bylaws-td30409.html > > >>>>>>>>>>>>>>>>>>>>>> The vote will be open for at least 6 days. PMC > > >>>>> members' > > >>>>>>>>>>> votes > > >>>>>>>>>>>>>>>> are > > >>>>>>>>>>>>>>>>>>>>>> considered as binding. The vote requires 2/3 > > >>>> majority > > >>>>>> of > > >>>>>>>>>>> the > > >>>>>>>>>>>>>>>>> binding > > >>>>>>>>>>>>>>>>>>>> +1s to > > >>>>>>>>>>>>>>>>>>>>>> pass. > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> Thanks, > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> Jiangjie (Becket) Qin > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>> > > > > >