Thanks, PSB. > -----Original Message----- > From: Shahed Shaikh <shsha...@marvell.com> > Sent: Thursday, November 7, 2019 1:57 PM > To: Dekel Peled <dek...@mellanox.com>; john.mcnam...@intel.com; > marko.kovace...@intel.com; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; > anatoly.bura...@intel.com; xuanziya...@huawei.com; > cloud.wangxiao...@huawei.com; zhouguoy...@huawei.com; > wenzhuo...@intel.com; konstantin.anan...@intel.com; Matan Azrad > <ma...@mellanox.com>; Shahaf Shuler <shah...@mellanox.com>; Slava > Ovsiienko <viachesl...@mellanox.com>; Rasesh Mody > <rm...@marvell.com>; maxime.coque...@redhat.com; > tiwei....@intel.com; zhihong.w...@intel.com; yongw...@vmware.com; > Thomas Monjalon <tho...@monjalon.net>; ferruh.yi...@intel.com; > arybche...@solarflare.com; jingjing...@intel.com; > bernard.iremon...@intel.com > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet > size > > > -----Original Message----- > > From: Dekel Peled <dek...@mellanox.com> > > Sent: Wednesday, November 6, 2019 7:58 PM > > To: john.mcnam...@intel.com; marko.kovace...@intel.com; > > nhor...@tuxdriver.com; ajit.khapa...@broadcom.com; > > somnath.ko...@broadcom.com; anatoly.bura...@intel.com; > > xuanziya...@huawei.com; cloud.wangxiao...@huawei.com; > > zhouguoy...@huawei.com; wenzhuo...@intel.com; > > konstantin.anan...@intel.com; ma...@mellanox.com; > > shah...@mellanox.com; viachesl...@mellanox.com; Rasesh Mody > > <rm...@marvell.com>; Shahed Shaikh <shsha...@marvell.com>; > > maxime.coque...@redhat.com; tiwei....@intel.com; > > zhihong.w...@intel.com; yongw...@vmware.com; > tho...@monjalon.net; > > ferruh.yi...@intel.com; arybche...@solarflare.com; > > jingjing...@intel.com; bernard.iremon...@intel.com > > Cc: dev@dpdk.org > > Subject: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO > > packet size > > > > External Email > > > > ---------------------------------------------------------------------- > > This patch implements [1], to support API for configuration and > > > > validation of max size for LRO aggregated packet. > > > > API change notice [2] is removed, and release notes for 19.11 > > > > are updated accordingly. > > > > > > > > Various PMDs using LRO offload are updated, the new data members are > > > > initialized to ensure they don't fail validation. > > > > > > > > [1] > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Furld > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttp- > &data=02%7C01%7Cdekelp > > > %40mellanox.com%7Cabfce6c19bcf4f42c75208d76379d781%7Ca652971c7d2e > 4d9ba > > > 6a4d149256f461b%7C0%7C1%7C637087247277571736&sdata=gWGd5Ew > ntdYj44F > > PZXNTG0uMivl42B0bE2%2FZ2izxV%2Fo%3D&reserved=0 > > > 3A__patches.dpdk.org_patch_58217_&d=DwIBAg&c=nKjWec2b6R0mOyPaz > 7xtf > > Q&r=qeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > > > cw6N6nsI&m=ghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=ANfM9 > GH > > SB9nUhm8O8YaoqcXO0eTBO7TmGhVmekbNO6U&e= > > > > [2] > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Furld > > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttp- > &data=02%7C01%7Cdekelp > > > %40mellanox.com%7Cabfce6c19bcf4f42c75208d76379d781%7Ca652971c7d2e > 4d9ba > > > 6a4d149256f461b%7C0%7C1%7C637087247277571736&sdata=gWGd5Ew > ntdYj44F > > PZXNTG0uMivl42B0bE2%2FZ2izxV%2Fo%3D&reserved=0 > > > 3A__patches.dpdk.org_patch_57492_&d=DwIBAg&c=nKjWec2b6R0mOyPaz > 7xtf > > Q&r=qeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > > > cw6N6nsI&m=ghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=ppYVW > Xe > > Jj3xhnvWCV2hIfNu6wy9N2r5lvJxgJnHKfSc&e= > > > > > > > > Signed-off-by: Dekel Peled <dek...@mellanox.com> > > > > Reviewed-by: Andrew Rybchenko <arybche...@solarflare.com> > > > > Acked-by: Thomas Monjalon <tho...@monjalon.net> > > > > --- > > > > doc/guides/nics/features.rst | 2 ++ > > > > doc/guides/rel_notes/deprecation.rst | 4 --- > > > > doc/guides/rel_notes/release_19_11.rst | 8 ++++++ > > > > drivers/net/bnxt/bnxt_ethdev.c | 1 + > > > > drivers/net/hinic/hinic_pmd_ethdev.c | 1 + > > > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > > > > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + > > > > drivers/net/mlx5/mlx5.h | 3 +++ > > > > drivers/net/mlx5/mlx5_ethdev.c | 1 + > > > > drivers/net/mlx5/mlx5_rxq.c | 1 - > > > > drivers/net/qede/qede_ethdev.c | 1 + > > > > drivers/net/virtio/virtio_ethdev.c | 1 + > > > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > > > > lib/librte_ethdev/rte_ethdev.c | 44 > > ++++++++++++++++++++++++++++++++ > > > > lib/librte_ethdev/rte_ethdev.h | 4 +++ > > > > 15 files changed, 70 insertions(+), 5 deletions(-) > > > > @@ -1277,6 +1277,7 @@ static int qede_dev_configure(struct rte_eth_dev > > *eth_dev) > > > > > > > > dev_info->min_rx_bufsize = (uint32_t)QEDE_MIN_RX_BUFF_SIZE; > > > > dev_info->max_rx_pktlen = > > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN; > > > > + dev_info->max_lro_pkt_size = > > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN > > Please use 0x7FFF instead of ETH_TX_MAX_NON_LSO_PKT_LEN. >
Sending v4 with this change. > We set the same limit in qede_ethdev.c: qede_update_sge_tpa_params() > > sge_tpa_params->tpa_max_size = 0x7FFF; > > Thanks, > Shahed > > > > dev_info->rx_desc_lim = qede_rx_desc_lim; > > > > dev_info->tx_desc_lim = qede_tx_desc_lim; > > > > Regards, Dekel
