> -----Original Message----- > From: Dekel Peled <dek...@mellanox.com> > Sent: Wednesday, November 6, 2019 7:58 PM > To: john.mcnam...@intel.com; marko.kovace...@intel.com; > nhor...@tuxdriver.com; ajit.khapa...@broadcom.com; > somnath.ko...@broadcom.com; anatoly.bura...@intel.com; > xuanziya...@huawei.com; cloud.wangxiao...@huawei.com; > zhouguoy...@huawei.com; wenzhuo...@intel.com; > konstantin.anan...@intel.com; ma...@mellanox.com; > shah...@mellanox.com; viachesl...@mellanox.com; Rasesh Mody > <rm...@marvell.com>; Shahed Shaikh <shsha...@marvell.com>; > maxime.coque...@redhat.com; tiwei....@intel.com; zhihong.w...@intel.com; > yongw...@vmware.com; tho...@monjalon.net; ferruh.yi...@intel.com; > arybche...@solarflare.com; jingjing...@intel.com; > bernard.iremon...@intel.com > Cc: dev@dpdk.org > Subject: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet size > > External Email > > ---------------------------------------------------------------------- > This patch implements [1], to support API for configuration and > > validation of max size for LRO aggregated packet. > > API change notice [2] is removed, and release notes for 19.11 > > are updated accordingly. > > > > Various PMDs using LRO offload are updated, the new data members are > > initialized to ensure they don't fail validation. > > > > [1] https://urldefense.proofpoint.com/v2/url?u=http- > 3A__patches.dpdk.org_patch_58217_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtf > Q&r=qeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > cw6N6nsI&m=ghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=ANfM9GH > SB9nUhm8O8YaoqcXO0eTBO7TmGhVmekbNO6U&e= > > [2] https://urldefense.proofpoint.com/v2/url?u=http- > 3A__patches.dpdk.org_patch_57492_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtf > Q&r=qeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > cw6N6nsI&m=ghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=ppYVWXe > Jj3xhnvWCV2hIfNu6wy9N2r5lvJxgJnHKfSc&e= > > > > Signed-off-by: Dekel Peled <dek...@mellanox.com> > > Reviewed-by: Andrew Rybchenko <arybche...@solarflare.com> > > Acked-by: Thomas Monjalon <tho...@monjalon.net> > > --- > > doc/guides/nics/features.rst | 2 ++ > > doc/guides/rel_notes/deprecation.rst | 4 --- > > doc/guides/rel_notes/release_19_11.rst | 8 ++++++ > > drivers/net/bnxt/bnxt_ethdev.c | 1 + > > drivers/net/hinic/hinic_pmd_ethdev.c | 1 + > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + > > drivers/net/mlx5/mlx5.h | 3 +++ > > drivers/net/mlx5/mlx5_ethdev.c | 1 + > > drivers/net/mlx5/mlx5_rxq.c | 1 - > > drivers/net/qede/qede_ethdev.c | 1 + > > drivers/net/virtio/virtio_ethdev.c | 1 + > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > > lib/librte_ethdev/rte_ethdev.c | 44 > ++++++++++++++++++++++++++++++++ > > lib/librte_ethdev/rte_ethdev.h | 4 +++ > > 15 files changed, 70 insertions(+), 5 deletions(-) > > @@ -1277,6 +1277,7 @@ static int qede_dev_configure(struct rte_eth_dev > *eth_dev) > > > > dev_info->min_rx_bufsize = (uint32_t)QEDE_MIN_RX_BUFF_SIZE; > > dev_info->max_rx_pktlen = > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN; > > + dev_info->max_lro_pkt_size = > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN
Please use 0x7FFF instead of ETH_TX_MAX_NON_LSO_PKT_LEN. We set the same limit in qede_ethdev.c: qede_update_sge_tpa_params() sge_tpa_params->tpa_max_size = 0x7FFF; Thanks, Shahed > > dev_info->rx_desc_lim = qede_rx_desc_lim; > > dev_info->tx_desc_lim = qede_tx_desc_lim; > >
