On 11/7/2019 12:35 PM, Dekel Peled wrote:
> @@ -1266,6 +1286,18 @@ struct rte_eth_dev *
> RTE_ETHER_MAX_LEN;
> }
>
> + /*
> + * If LRO is enabled, check that the maximum aggregated packet
> + * size is supported by the configured device.
> + */
> + if (dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_TCP_LRO) {
> + ret = check_lro_pkt_size(
> + port_id, dev_conf->rxmode.max_lro_pkt_size,
> + dev_info.max_lro_pkt_size);
> + if (ret != 0)
> + goto rollback;
> + }
> +
This check forces applications that enable LRO to provide 'max_lro_pkt_size'
config value.
- Why it is mandatory now, how it was working before if it is mandatory value?
- What happens if PMD doesn't provide 'max_lro_pkt_size', so it is '0'?
- What do you think setting 'max_lro_pkt_size' config value to what PMD provided
if application doesn't provide it?
