tabac commented on PR #136: URL: https://github.com/apache/datasketches-rust/pull/136#issuecomment-4591444254
@tisonkun I pushed another commit for the Bloom, Tdigest and Theta sketches which are straight forward compared to CountMin and Frequencies that store a generic type `T`. I will follow up for the remaining two in another PR. My only concern is that all the functions use the same name but some report only heap memory while others report stack + heap. This could be confusing although we mention in the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
