tabac commented on PR #136: URL: https://github.com/apache/datasketches-rust/pull/136#issuecomment-4572658410
> > estimated_size_bytes > > A bit repeated? `estimated_bytes` generally implies "size" or actually `estimated_size` with a comment saying it's in bytes should work. Just `heap_size` sounds to me too technical :P OK, I can push a commit with the rename. Just to make sure: we want both `size()` and `heap_size()` to be renamed to `estimated_size()` right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
